Adds support for MatchXML #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubm
force-pushed
the
adds-support-for-match-xml
branch
3 times, most recently
from
8287255 to
cd318f7
Compare
|
Sweet! Unfortunately it looks like this broke 1.6 and 1.7 on Travis. Any chance you could take a look? |
|
Yes I'm trying to figure it out. |
|
👍 |
|
It seems that this particular struct field tag I will have to search for another approach, too bad... |
|
Possibly there could be specific code for (I did not look for other solutions yet). |
|
I'm no expert on the vagaries of XML support in Go but I'm OK with version dependent behavior as long as it is documented clearly in godoc and the gh-pages branch.
… On Apr 29, 2017, at 9:32 AM, Aurélien Baumann ***@***.***> wrote:
Possibly there could be specific code for <1.8, minus the support for attributes checking.
It is not super clean... what is your opinion on this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
aubm
force-pushed
the
adds-support-for-match-xml
branch
2 times, most recently
from
a6b7b3d to
e2125a3
Compare
Actual and expected can not be pretty printed in the test output because there are issues in the encoding/xml package related to deplicated namespaces. See golang/go#7535 Because Go has no support for collecting all XML attributes before 1.8 (see [here](golang/go@c1a1328)), the two following XMLs will be equal for 1.7 and before: ``` <person gender="female"> ``` ``` <person gender="male"> ```
aubm
force-pushed
the
adds-support-for-match-xml
branch
from
e2125a3 to
a93bfc7
Compare
|
It should be ok now. |
|
Ok thanks. Can you submit a PR for the gh-pages docs as well? |
|
Done: #210 |
|
Sweet thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual and expected can not be pretty printed in the test output because
there are issues in the encoding/xml package related to deplicated
namespaces. See golang/go#7535
Because Go has no support for collecting all XML attributes before 1.8
(see here), the two following XMLs will be equal for 1.7 and before: