Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to INFO requests in dialog #1

Closed
wakamoleguy opened this issue Apr 4, 2014 · 3 comments
Closed

Respond to INFO requests in dialog #1

wakamoleguy opened this issue Apr 4, 2014 · 3 comments
Labels

Comments

@wakamoleguy
Copy link
Contributor

Currently, we ignore non-DTMF INFO requests. Applications such as FreeSWITCH send INFO packets in dialogs. We should acknowledge their receipt with a 200 Okay.

@etamme
Copy link
Collaborator

etamme commented Apr 4, 2014

In a naive implementation one can simply follow the rules for responding in:

https://tools.ietf.org/html/rfc2976#page-5

"If a server receives an INFO request with a body it understands,
but it has no knowledge of INFO associated processing rules for
the body, the body MAY be rendered and displayed to the user. The
INFO is responded to with a 200 OK.

If the INFO request contains a body that the server does not
understand then, in the absence of INFO associated processing
rules for the body, the server MUST respond with a 415 Unsupported
Media Type message."

@josephfrazier josephfrazier self-assigned this May 1, 2014
@josephfrazier josephfrazier removed their assignment May 1, 2014
@james-criscuolo
Copy link
Collaborator

I looked at the commit, looks fine. It was very odd that the DTMF test would suddenly start breaking, but I reintroduced it and added the 415 case as a test as well.

@josephfrazier
Copy link
Contributor

merged at 44f543c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants