Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1xx INVITE reliable response received out of order, dropping. #805

Closed
jbort-icr opened this issue May 4, 2020 · 1 comment · Fixed by #811
Closed

1xx INVITE reliable response received out of order, dropping. #805

jbort-icr opened this issue May 4, 2020 · 1 comment · Fixed by #811

Comments

@jbort-icr
Copy link

We are using rel100/PRACK configuration to allow calls with 'early media'. It's working fine in calls with only one 1xx message but when there are multiple 1xx messages in the SIP dialog we are geting "1xx INVITE reliable response received out of order, dropping." and the call is not established properly.

We attach logs for an 'Invite' that receives 181,180,183 responses (1xx INVITE reliable response received out of order, dropping.txt)

It's allways reproducing for a 'Invite' response sequence 181,180,183.

We fixed this behaibour with a patch (
0001-Try-to-allow-multiples-1xx-responses-for-100rel-PRAC.zip).

But we don't know if it's right. Can some developer help us? We can collaborate colleting, developing or testing.
john-e-riordan pushed a commit to john-e-riordan/SIP.js that referenced this issue May 11, 2020
Fix reliable response handling bug
fffd1d7 
For a given request, all reliable provisional responses
after the first 2 were being dropped. The rseq was
not begin tracked properly by the UAC, so fixed that.
Also added a test for it.

Fixes onsip#805
@john-e-riordan john-e-riordan mentioned this issue May 11, 2020
Merged
@john-e-riordan
Copy link
Collaborator

Thanks for reporting the issue. The logs and patch were very helpful. I've submitted a pull request which fixes the issue basically the same way your patch does.

In short, for a given request, only the first 2 reliable provisional responses were being handled and any additional responses were being dropped. I was able to easily reproduce the issue with a test once I knew what to test for.

Can you please test again once the pull request gets pulled in and confirm it works? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reliable response handling bug john-e-riordan/SIP.js
2 participants
@john-e-riordan @jbort-icr