session-manager.ts: Optionally send DTMF via SDH. #1013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-e-riordan
pushed a commit
that referenced
this pull request
Oct 25, 2022
|
Made a few small modifications to naming and so forth, but done and released in 0.21.1. I needed to push a fix to 0.21.0 so added this along with it. Anyway, others have asked for the same, so thanks for getting this started and moving along. |
|
Great! Thanks for including this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously the setting name is bad and probably in the wrong place but I wanted a baseline to get a conversation going.
I want to be able to send DTMF via RTP with
SimpleUser(I really don't want to roll my own version ofSimpleUserjust for this). Thoughts on if this is something you will entertain and, if so, what would you accept in terms of configuration flag/location?