Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to make an
onAck
session delegation, so we'll be able to catch when we are getting a SIP ACK from PBX side.This helps to reduce race conditions, because currently the only way to detect when a call is REALLY being answered is to listen on the session state when it becomes
SessionState.ESTABLISHED
, usually it becomes ESTABLISHED before the ACK arrives. But waiting for ACK and acting accordingly is more reliable way.Note: this is my first PR here, I hope it is done according to your guidelines (which I couldn't find).