Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of objects in logical axioms with export #65

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

beckyjackson
Copy link
Collaborator

While working with Cell Ontology, I wanted to export details about the plasma membrane parts. Currently, if you include "has plasma membrane part" as one of the predicates, it won't return any values, since this is a logical axiom on a class in the format

'has plasma membrane part' some foo

I think we should distinguish between object & annotation properties when retrieving values for export so that the object "foo" will be returned in the previous case. Right now, only object properties on classes are supported, and cardinality is not included. So if you had the axiom:

'has plasma membrane part' exactly 1 foo

.. it would just return "foo".

I'm leaving this as a draft PR because it may need some fleshing out, but it's a really convenient feature to have.

Note that there are some randoms diffs from running black, but these should go away once we merge in #63

@beckyjackson beckyjackson marked this pull request as ready for review February 23, 2021 20:28
@jamesaoverton
Copy link
Member

I think we'll end up using Thick Triples for this instead, but we are using this branch right now for a few things, so I'll leave it open.

@jamesaoverton jamesaoverton removed their request for review June 11, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants