Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update owl-diff dependency for stable ordering and to avoid large string creation #1227

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

balhoff
Copy link
Contributor

@balhoff balhoff commented Nov 19, 2024

Resolves #1192. owl-diff now accepts a Writer or OutputStream so it can avoid creating a huge string. Also, the ordering of output should be consistent.

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

@balhoff
Copy link
Contributor Author

balhoff commented Nov 19, 2024

I need to check the mvn verify results, since something is causing an error at the moment.

Fixed by removing unnecessary flush() call.

@jamesaoverton
Copy link
Member

This seems straightforward to me, and it passes the tests. Ready for me to merge it @balhoff?

@balhoff
Copy link
Contributor Author

balhoff commented Nov 20, 2024

Thanks @jamesaoverton, I think it's ready.

@jamesaoverton jamesaoverton merged commit ff47bff into master Nov 20, 2024
3 checks passed
@jamesaoverton jamesaoverton deleted the owl-diff-update branch November 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diff feature request: sort axioms in Added and Removed sections in Markdown output
2 participants