Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Refactor and fix the Language filter method #41

Merged
merged 11 commits into from
Jul 14, 2023

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Jul 14, 2023

Context

This PR does a global rewrite and refactor of all the work done in the Multilingual topic with the PRs listed bellow

Changes

  • Give better names to the methods
  • Remove unused methods and variables
  • Limit the coupling between the two modules of SolutionMapper and LangFilter;
  • Replace the getters argument to show languages from :show_all_languages to show_languages: true (e26009a)
  • Fix save_model_values method to not save RDF:Literal object but a string (a990260)
  • Fix getters for list attributes to not take only the first value (94959cd)

@syphax-bouazzouni syphax-bouazzouni merged commit 10722be into development Jul 14, 2023
syphax-bouazzouni added a commit that referenced this pull request Sep 5, 2023
Feature: Refactor and fix the Language filter method
syphax-bouazzouni added a commit that referenced this pull request Dec 4, 2023
* Merge pull request #24 from ontoportal-lirmm/feature/support-multilingual-read-one-language-from-request-parameter

Feature : Support multilingual - Phase 1 - Read one language

* Merge branch pull request #32 from feature/language-return-all

* group unmapped properties by lang

* Feature: group unmapped properties by language  (#38)

* group unmapped properties by lang

* downcase language keys of unmapped properties

---------

Co-authored-by: Syphax bouazzouni <gs_bouazzouni@esi.dz>

* Feature: Support multi lingual -  add show_language argument to the attributes getters (#39)

* update define_method

* update solution mapper

* update get_preload_value

* Merge pull request #40 from ontoportal-lirmm/support-muli-lang-part-02

Fix: save_model_values if unmmaped condition

* Merge pull request #41 from ontoportal-lirmm/support-muli-lang-part-02

Feature: Refactor and fix the Language filter method

* Merge pull request #42 from ontoportal-lirmm/feature/support-multi-langual-search

Feature: Make map_attribute support showing all languages - Support multi language search

---------

Co-authored-by: HADDAD Zineddine <hz_haddad@esi.dz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant