Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: create graphs endpoints to list, create and delete #115

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Feature: create graphs endpoints to list, create and delete #115

merged 6 commits into from
Jan 23, 2025

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Jan 13, 2025 •
edited
Loading

Changes

  • Add endpoint GET /admin/graphs to list current triple store paths
  • Add endpoint POST /admin/graphs generate graphs counts file
  • Add endpoint DELETE /admin/graphs?url=<graph uri> delete a graph

All this endpoint require the user to be an admin

@syphax-bouazzouni syphax-bouazzouni mentioned this pull request Jan 13, 2025
Draft
syphax-bouazzouni
syphax-bouazzouni commented Jan 20, 2025
View reviewed changes
Copy link
Author

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the actions generate and delete graphs could have been handled better as they may raise timeouts, but for now we don't have better ways to handle long run actions.

@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/create-graphs-endpoints branch from 9cf7d30 to fde30dc Compare January 23, 2025 20:21
@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/create-graphs-endpoints branch from fde30dc to a3fb4fb Compare January 23, 2025 21:09
@syphax-bouazzouni syphax-bouazzouni changed the title Feature: Create graphs endpoints Feature: create graphs endpoints to list, create and delete Jan 23, 2025
@syphax-bouazzouni syphax-bouazzouni self-assigned this Jan 23, 2025
@syphax-bouazzouni syphax-bouazzouni merged commit 07290db into development Jan 23, 2025
24 checks passed
This was referenced Feb 6, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@syphax-bouazzouni syphax-bouazzouni

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@syphax-bouazzouni