Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: mappings statistics slices support #78

Merged
merged 3 commits into from
May 21, 2024

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented May 20, 2024

Done

  • Made the endpoint /mappings/statistics/ontologies/ supports slices (when we call it from a slice then limit the ontologies only to the ontologies of this slice)
  • Add a test for that

@Bilelkihal Bilelkihal self-assigned this May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.62%. Comparing base (85617ad) to head (8a212e5).
Report is 13 commits behind head on development.

Current head 8a212e5 differs from pull request most recent head aa9c766

Please upload reports for the commit aa9c766 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff               @@
##           development      #78      +/-   ##
===============================================
+ Coverage        71.26%   71.62%   +0.36%     
===============================================
  Files               67       67              
  Lines             3508     3648     +140     
===============================================
+ Hits              2500     2613     +113     
- Misses            1008     1035      +27     
Flag Coverage Δ
unittests 71.62% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imadbourouche imadbourouche merged commit 5c03e7e into development May 21, 2024
24 checks passed
syphax-bouazzouni added a commit that referenced this pull request May 22, 2024
…RI content negotiation and Ontology metadata and data indexation (#73)

* Feature: Migrate to virtuoso (#67)

* set up multiple triple store test environment

* optimize api tests

* Fix: update ncbo_annotator gem version (#71)

* update ncbo_annotator gem version

* update alegrograph to version 8.1.0

* Feature: use the new  SOLR Schema API instead of SOLR config files  (#68)

* update docker compose to use standard SOLR not the ontoportal configured

* update term search to use the new Schema API and remove config files

* update properties search to use the new Schema API & remove config files

* update class and properties schema to use the existent dynamic names

* Feature: resolving resources within specific ontologies, supporting various output formats(#69)

* remove useless line preventing sending the reset password email (#65)

* [ontoportal-bot] Gemfile.lock update

* Feature: api endpoint returns json-ld  for the element with that URI

* implement GET, POST requests, and GET /parse to submit INRATHES ontology

* Enhance tests using real data submission

* Enhance bin/ontoportal to make it able to run localy with UI

* Small fixes

- change controller name and test controller name
- remove /parse endpoint
- rackup to shotgun in bin/ontoportal

* Fix test dereference resource controller

- in json test, before we test the result we sort the hashes with the function (sort_nested_hash)
- in xml, ntriples and turtle, we split the result and the expected result, sort them and compare them

* update gemfile: add json-ld (3.0.2)

* change derefrencement namespacing and clean code

* Fix dereference resource tests expected resultsto handle parse triples

* fix xml serialization test for AG and Gb by cleaning the xml string

---------

Co-authored-by: OntoPortal Bot <ontoportal.bot.lirmm@gmail.com>
Co-authored-by: imadbourouche <ji_bourouche@esi.dz>

* Feature: URI drerfrencement content negotiation (#72)

* remove useless line preventing sending the reset password email (#65)

* [ontoportal-bot] Gemfile.lock update

* Feature: api endpoint returns json-ld  for the element with that URI

* implement GET, POST requests, and GET /parse to submit INRATHES ontology

* Enhance tests using real data submission

* Enhance bin/ontoportal to make it able to run localy with UI

* Small fixes

- change controller name and test controller name
- remove /parse endpoint
- rackup to shotgun in bin/ontoportal

* Fix test dereference resource controller

- in json test, before we test the result we sort the hashes with the function (sort_nested_hash)
- in xml, ntriples and turtle, we split the result and the expected result, sort them and compare them

* update gemfile: add json-ld (3.0.2)

* change derefrencement namespacing and clean code

* Fix dereference resource tests expected resultsto handle parse triples

* Feature: add content negotiation middleware

* Add headers to tests instead of output_format

* Apply middleware to only /ontologies/:acronym/resolve/:uri

* Add test cases for AllegroGraph and fix xml test

* move the content_negotiation middleware into rack folder and  module

* re-implement again the usage of  the output_format param if no format is given in the request header

* clean the tests for no more necessary checks

* clean and simplify the content negotiation middleware

* add the accepted format in the error response of resolvability endpoint

* refactor the content negotiation middleware code to be more clear

---------

Co-authored-by: Syphax bouazzouni <gs_bouazzouni@esi.dz>
Co-authored-by: OntoPortal Bot <ontoportal.bot.lirmm@gmail.com>

* Fix: user creation security  (#60)

* extract slice tests helper to the parent class for reusability

* add a test for the creation of an admin user

* enforce the security of admin user creation

* update slices controller to enforce admin security

* Fix: the content negotiation by removing a no needed require

* Feature: Indexation administration & Ontologies and Agents search  (#70)

* index submission and agents metadata

* add search administration endpoints to init schema and index batch

* add ontology and agent search endpoints

* add agent and ontology search tests

* add admin search in collections

* make the search admin use directly the solr connector

* implement search ontologies content search endpoint

* enforce solr models indexing one by one to prevent batch fails

* add detType tov search ontologies  content search endpoint

* fix content ontology search pagination

* add ontology search content types filter

* Feature: Add accessibility security to ontology metadata & content search results  (#74)

* add ontology accessibility restriction  to ontology metadata search

* add ontology accessibility restriction  to ontology content search

* add search results accessibility security test

* fix: enable user creation notification (#76)

* Fix: Invalidating cache on insert & fix Redis warning (#77)

* Merge pull request https://github.com/ncbo/ontologies_api/pull/120from ncbo/remove_redis-activesupport

Remove redis activesupport

* use the branch development of sparql client

* Feature: mappings statistics slices support (#78)

* restrict mapping statistics ontologies to the ontologies of the current slice

* add a test for the mappings slices support

* add test for mappings statistics slices support

---------

Co-authored-by: OntoPortal Bot <ontoportal.bot.lirmm@gmail.com>
Co-authored-by: imadbourouche <ji_bourouche@esi.dz>
Co-authored-by: Bilel Kihal <61744974+Bilelkihal@users.noreply.github.com>
syphax-bouazzouni pushed a commit that referenced this pull request Jun 26, 2024
* restrict mapping statistics ontologies to the ontologies of the current slice

* add a test for the mappings slices support

* add test for mappings statistics slices support
syphax-bouazzouni added a commit that referenced this pull request Jun 26, 2024
…es of resources with no owl:Ontology (#81)

* Feature: mappings statistics slices support (#78)

* restrict mapping statistics ontologies to the ontologies of the current slice

* add a test for the mappings slices support

* add test for mappings statistics slices support

* update owl wrapper version to v1.4.3

---------

Co-authored-by: Bilel Kihal <61744974+Bilelkihal@users.noreply.github.com>
syphax-bouazzouni added a commit that referenced this pull request Aug 8, 2024
* Feature: mappings statistics slices support (#78)

* restrict mapping statistics ontologies to the ontologies of the current slice

* add a test for the mappings slices support

* add test for mappings statistics slices support

* update owl wrapper version to v1.4.3

* update test search multilingual test to ensure selecting one prefLabel

* add filter search results attributes by language

* add search  multiple languages or all languages tests

* implement display search results in multiple languages

* fix annotator prefLabel language selection

* fix: remove duplicated agents endpoint ('/Agents') (#85)

* Feature: implement ontology agents endpoint (#84)

* implement ontology agents endpoint

* Move ontology agents method out of agents namespace in agents_controller

* return a list of uniq values, for the endpoint '/ontologies/:acronym/agents' that contains all the agents of the ontology using agents_attrs list

* test for ontology agents endpoing

* add another ontologyin test ontology agents test, and assert only the number of results and the names

---------

Co-authored-by: Bilel KIHAL <kb_kihal@esi.dz>

* update API deploy CI  to SSH jump host and get configs from private repo

* update deploy files and add agroportal, stage and test environments

* Feature: update agents search endpoint to add option to have a custom qf paramter  (#90)

* fix agents search sensibility

* improve agents search endpoint to search only exact string or substring match

* make the agent search endpoint query filter configurable

---------

Co-authored-by: Syphax <gs_bouazzouni@esi.dz>

* Fix: hide duplicated agents endpoint ('/Agents')  (#91)

* remove duplicated agents endpoint ('/Agents')

* put again the Agents endpoint

* hide Agents endpoint in the home endpoint

* fix properties tests

---------

Co-authored-by: Bilel KIHAL <kb_kihal@esi.dz>

---------

Co-authored-by: Bilel Kihal <61744974+Bilelkihal@users.noreply.github.com>
Co-authored-by: Bilel KIHAL <kb_kihal@esi.dz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants