submission notification is not working

[syphax-bouazzouni]

An email notification normally would be sent if any submission is parsed. But it seems that we have never seen it worked.

The code responsible on sending it is here : https://github.com/ontoportal-lirmm/ontologies_linked_data/blob/master/lib/ontologies_linked_data/models/ontology_submission.rb#L1923

And it's an "ensure" clause, which means that whatever happen (exception or not ) the email notification will be sent.

The mail is defined here : https://github.com/ontoportal-lirmm/ontologies_linked_data/blob/master/lib/ontologies_linked_data/utils/notifications.rb#L63

[syphax-bouazzouni]

Issue updates

It seems that the submission notification is sent for only the users that are subscribed to the ontology, with a subscription of type "PROCESSING" or "ALL" (and not of type "NOTE")

Solution

Change the mail recipient's behavior for the notifications :

• new_note => notify subscribed to the ontology(separately) (note: ontology administrators are not subscribed by default?)
• submission_processed => notify subscribed(separately) + ontology_adminstrators and support mails (all grouped)(changed: added support and ontology_adminstrators mails)
• remote_ontology_pull => notify ontology_adminstrators and support mails (all grouped)
• new_user => notify support mails (grouped)
• new_ontology => notify support mails (grouped)
• reset_password => notify the user that is resetting it password
• obofoundry_sync => notify the support mails (grouped)

working branch: https://github.com/ontoportal-lirmm/ontologies_linked_data/compare/master...ontoportal-lirmm:pl/refactor-notifications?expand=1

Tests

https://github.com/ontoportal-lirmm/ontologies_linked_data/actions/runs/2077179672

Deploy on

• testportal
• stageportal
• agrportal
• bioportal

[syphax-bouazzouni]

fixed :