-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding npm scripts for compiling ES5 dist through babel #6
Conversation
Thanks @criography. I'd like to merge this but 2 points:
Would you mind updating your PR for this? |
…oint to it by default
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invert
object is not exposed properly in DOM. It was exported as window.index
per the filename.
package.json
Outdated
"scripts": { | ||
"test": "node test", | ||
"build": "babel src --presets es2015 --out-dir dist", | ||
"watch": "babel -w src --presets es2015 --out-dir dist" | ||
"build": "babel src --presets es2015 --plugins transform-es2015-modules-umd --out-dir dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way in DOM, it's exposed as window.index
, not window.invert
.
That's better. |
This PR adds a build script that would allow to use this library in opinionated environments ESNext is not fully supported, like create-react-app.
It doesn't alter the source at all.