Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an audible notification after text generation in web. #1277

Merged
merged 3 commits into from
May 20, 2023

Conversation

HappyWorldGames
Copy link
Contributor

If there is a file "notification.mp3" in the root.

@HappyWorldGames HappyWorldGames changed the title I added an audible notification after text generation in web. Added an audible notification after text generation in web. Apr 16, 2023
@mcmonkey4eva
Copy link
Contributor

Could you rebase/merge against the new main? There's been changes to the same sections of code which prevent it from merging.

Also, perhaps add a comment in the docs somewhere about this?

When I implemented the same feature for a different project I tossed in a link to https://bigsoundbank.com/search?q=notification as an example of where to get files for it.

Copy link
Contributor

@mcmonkey4eva mcmonkey4eva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the above-noted merge issue and suggested docs, I tested this PR and it works as intended. Notification sound plays in-web-browser when generating is done.

@oobabooga oobabooga merged commit a3e9769 into oobabooga:main May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants