Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAI extension list currently loaded models not dummy models. #5720

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

jonnysowards
Copy link

Fixes bug #5675 that lists dummy models instead of loaded models in OpenAI extension. v1/models.

Checklist:

Fixes bug oobabooga#5675 that lists dummy models instead of loaded models in OpenAI extension. v1/models.
@jonnysowards jonnysowards changed the title Update script.py OpenAI extension list currently loaded models not dummy models. Mar 18, 2024
…ple.

Change openai models list result output to match the dummy model example.
@Ph0rk0z
Copy link
Contributor

Ph0rk0z commented Mar 27, 2024

What will this do to tools that expect openAI models or choose them?

@jonnysowards
Copy link
Author

jonnysowards commented Mar 28, 2024

@Ph0rk0z That is one of my concerns. When using integrations like continue.dev the proper models do not load via the open ai api endpoints, only dummy ones that do not work. Although if another integration is required to have to have the open ai models to verify its working then this could cause it to fail. I'm wondering if potentially a flag could denote whether or not to use dummy models.

@Ph0rk0z
Copy link
Contributor

Ph0rk0z commented Apr 1, 2024

Why not just add gpt4/3.5 fake model strings in addition to the actual models and make those not switch the current model? Kill two birds with one stone in a way.

@jonnysowards
Copy link
Author

@Ph0rk0z That sounds like the best of both worlds, and easy to implement. I will update the pull to do that when I get a minute.

@danny-avila
Copy link

Just commenting here. @oobabooga this should be merged, very minor and easy fix resolving a modest pain point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants