Fix for systems that have bash in a non-standard directory #6428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As talked on #6386 This fixes the software once again on NixOS, while still forcing bash as 6386 did. (honestly I’m skeptical that the shell conda is ran from makes a difference, it definitely shouldn’t since the program (conda) itself should call the necessary shell if needed, buuuuuuut after the deeply traumatising experience of reading the miniconda installer script a while ago for some troubleshooting it wouldn’t surprise me at all if conda didn’t check before using bash syntax on sh to do some cursed stuff)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked on #6386
This fixes the software once again on NixOS, while still forcing bash as 6386 did.
(honestly I’m skeptical that the shell conda is ran from makes a difference, it definitely shouldn’t since the program (conda) itself should call the necessary shell if needed, buuuuuuut after the deeply traumatising experience of reading the miniconda installer script a while ago for some troubleshooting it wouldn’t surprise me at all if conda didn’t check before using bash syntax on sh to do some cursed stuff)
Checklist: