Update CsWin32 version (#137) #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CsWin32 version and fixed various breaking changes.
One of the things I ran into was that it seemed like .NET Core 3.1 no longer compiles in this project. It seems like 3.1 has a dependency on CompilerServices.Unsafe 4.x.x.x and CsWin32 now requires version 6.x.x.x. This was causing: 1. Conflicting version warnings in the 3.1 build. 2. Compile errors since version 4.x.x.x was a primary reference, it didn't support Unsafe.SkipInit. Since core 3.1 is out of support, I figured it would be easiest to just drop it since it was causing problems. I've also dealt with enough nuget versioning issues to know that this likely is a pain to solve.