Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Microsoft.Windows.CsWin32 to generate P/Invoke methods #84

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Use Microsoft.Windows.CsWin32 to generate P/Invoke methods #84

merged 2 commits into from
Sep 28, 2022

Conversation

virzak
Copy link
Contributor

@virzak virzak commented Dec 15, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@augustoproiete
Copy link
Member

Thanks for the PR @virzak ! 👍🏻

Could you create an issue in this repo with the elevator pitch for moving to CsWin32 on this library? I'm definitely not against it, but I'd like to understand the value we get given all the P/Invoke definitions have already been written and have been battle tested for many years.

Also, if we were to go this route, would we be able to use a stable version of the Microsoft.Windows.CsWin32 package directly from the nuget.org feed?

@virzak virzak mentioned this pull request Dec 16, 2021
Closed
@virzak
Copy link
Contributor Author

virzak commented Dec 16, 2021

Logged #85.

Yes, the nuget.org version works as well. Something wasn't working during development and I just tried the latest build of the library. Turned out it wasn't at fault. If you'd like I can revert.

@augustoproiete augustoproiete linked an issue Dec 16, 2021 that may be closed by this pull request
Switch to Microsoft.Windows.CsWin32 #85
Closed
@virzak virzak force-pushed the cswin32-squashed branch 2 times, most recently from bd582d1 to 886846b Compare February 4, 2022 04:11
@virzak
Copy link
Contributor Author

virzak commented Feb 4, 2022

Now using the latest version from nuget instead of a private feed.

@FirehawkV21 FirehawkV21 mentioned this pull request Sep 15, 2022
Open
@virzak
Copy link
Contributor Author

virzak commented Sep 27, 2022

@augustoproiete, any chance of merging this soon? I'd like to submit another PR which conflicts with this, so if you have a chance to look at this soon, it would avoid future conflict.

augustoproiete
augustoproiete approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@augustoproiete augustoproiete merged commit a0386d8 into ookii-dialogs:master Sep 28, 2022
@augustoproiete
Copy link
Member

@virzak Merged. Sorry for the long delay

@virzak virzak deleted the cswin32-squashed branch September 29, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustoproiete augustoproiete augustoproiete approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to Microsoft.Windows.CsWin32
3 participants
@virzak @CLAassistant @augustoproiete