Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prometheus configuration to ooni/devops #32

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Move prometheus configuration to ooni/devops #32

merged 5 commits into from
Apr 8, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Mar 19, 2024

In this PR we move the prometheus configuration from ooni/sysadmin into ooni/devops.

As part of this work I also deleted pieces of the original configuration that were effectively dead code.

Going forward we should only deploy changes to the monitoring configuration from ooni/devops and we should update the developer docs where relevant.

As an interim safety running the playbook for monitoring will display a warning message and not run in ooni/sysadmin: ooni/sysadmin#519.

Copy link

github-actions bot commented Mar 19, 2024

Ansible Run Output 🤖

Ansible Playbook Recap 🔍



Ansible playbook output 📖success

Show Execution

$ ansible-playbook playbook.yml --check --diff -i ../tf/modules/ansible_inventory/inventories/inventory-dev.ini
[WARNING]: provided hosts list is empty, only localhost is available. Note that
the implicit localhost does not match 'all'
[WARNING]: Could not match supplied host pattern, ignoring: clickhouse_servers
[WARNING]: Could not match supplied host pattern, ignoring: monitoring.ooni.org

PLAY [ClickHouse servers] ******************************************************
skipping: no hosts matched

PLAY [Update monitoring config] ************************************************
skipping: no hosts matched

PLAY RECAP *********************************************************************

Pusher @hellais
Action pull_request
Working Directory
Workflow .github/workflows/check_ansible.yml
Last updated Tue, 19 Mar 2024 16:08:50 GMT

@hellais hellais requested a review from DecFox March 19, 2024 16:07
Copy link
Contributor

@DecFox DecFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hellais hellais merged commit 7d1fc3b into main Apr 8, 2024
3 checks passed
hellais added a commit to ooni/sysadmin that referenced this pull request Apr 8, 2024
@hellais hellais deleted the monitoring branch April 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants