fix: add support for darwin/arm64 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff ensures we hardcode the capabilities of darwin/arm64. While there, strive to make the packages naming slightly less confusing. Reference issue: ooni/probe#2122. Surpersedes (and draws from) #5. Co-authored-by: ain ghazal <ainghazal42@gmail.com>
This was referenced Aug 18, 2022
bassosimone
added a commit
that referenced
this pull request
Aug 22, 2022
This diff backports code to correctly handle darwin/arm64 from `main` (see #7). While there, this diff aims at reducing unnecessary differences with the main branch, by removing code we also removed in there. The reference issues are: 1. ooni/probe#2122 2. ooni/probe#2223
bassosimone
added a commit
that referenced
this pull request
Aug 22, 2022
This diff backports code to correctly handle darwin/arm64 from `main` (see #7). While there, this diff aims at reducing unnecessary differences with the main branch, by removing code we also removed in there. The reference issues are: 1. ooni/probe#2122 2. ooni/probe#2223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff ensures we hardcode the capabilities of darwin/arm64.
While there, strive to make the packages naming slightly less confusing.
Reference issue: ooni/probe#2122.
Surpersedes (and draws from) #5.
Co-authored-by: ain ghazal ainghazal42@gmail.com