Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve communication of which websites are tested by OONI Probe #502

Closed
wants to merge 5 commits into from

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Apr 2, 2022

Fixes ooni/probe#1929 , ooni/probe#1935

Proposed Changes

  • Added Support for android viewBinding.
  • Add button to load websites (loadFromWebConnectivity) used in web_connectivity test in CustomWebsiteActivity.
  • Fetch and display websites in webconnectivity when loadFromWebConnectivity button is clicked, making loadFromWebConnectivity invisible when successful.
. . .
Screenshot_20220402_075718 Screenshot_20220402_075743 Screenshot_20220402_075758

@aanorbel aanorbel requested review from bassosimone and hellais April 6, 2022 09:16
@hellais
Copy link
Member

hellais commented Apr 6, 2022

TODO:

  • Verify if the maxRuntime is being respected when the full list is fetched from the backend and the test is started
  • Tighten up the padding between the URL entries
  • Fix the positioning of the delete button

@aanorbel
Copy link
Member Author

aanorbel commented Apr 7, 2022

  • Tighten up the padding between the URL entries
  • Fix the positioning of the delete button

Screenshot_20220407_061150

@@ -66,18 +66,22 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
RunningActivity.runAsForegroundService(CustomWebsiteActivity.this, suite.asArray(), this::finish);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RunningActivity.runAsForegroundService(CustomWebsiteActivity.this, suite.asArray(), this::finish);
// Condition below is only true if the `loadFromWebConnectivity` has been clicked.
if (binding.loadFromWebConnectivity.getVisibility() == View.INVISIBLE) {
suite.getTestList(preferenceManager)[0].setMax_runtime(preferenceManager.getMaxRuntime());
}
RunningActivity.runAsForegroundService(CustomWebsiteActivity.this, suite.asArray(), this::finish);

@hellais , what do you think about this.

@aanorbel aanorbel marked this pull request as draft June 18, 2022 14:41
@aanorbel aanorbel closed this Sep 1, 2023
@aanorbel aanorbel deleted the issues/1929 branch October 21, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve communication of which websites are tested by OONI Probe
2 participants