Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(netxlite): HTTPSSvc: better no_answer checks
I've seen some measurements returning some IP addresses for HTTPSSvc queries but not returning any ALPN value. For example: ```JSON % d4 decoding DNS round trip 0: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 57768 ;; flags: rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;psiphon.ca. IN HTTPS ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 57768 ;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;psiphon.ca. IN HTTPS ;; ANSWER SECTION: psiphon.ca. 121 IN A 31.13.85.53 ``` Now, the response is clearly bogus. At the time of this writing that IP address belongs to Facebook. This measurement has been collected in China, so it's expected for the GFW to behave like this. Yet, I don't feel like it's accurate to report this measurement as a "no answer" response. Rather, this response is a valid one containing a clearly invalid IP address and should be flagged as such. Originally: bassosimone/websteps-illustrated@57a023b See ooni/probe#2096
- Loading branch information