feat: mechanism compile and embed tor #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mechanism should replace github.com/ipsn/go-libtor. Still work in progress. Reference issue: ooni/probe#2365
4 tasks
bassosimone
added a commit
that referenced
this pull request
Feb 3, 2023
I want to understand why we did not see this error previously. My initial hypothesis is that the code at ooni/go-libtor behaved behaved differently than #1052. To understand whether this is the case, in this patch I have copied the code at libtor/libtor.go and adapted it such that we can use it inside the current tree. Part of ooni/probe#2405.
bassosimone
added a commit
that referenced
this pull request
Feb 3, 2023
It turns out previously we were not using the control conn. Using such a conn is not the default and needs to be configured. However, the code at #1052 tries to be immutable and hence has a different algorithm than the one inside go-libtor. In particular, this new code always creates a control connection and then closes it. So, definitely the new code I wrote is such that it triggers the tor issue. On the other end, to hope to see the issue with go-libtor we must enable using the control conn. Let us do that and see. Part of ooni/probe#2405.
This was referenced Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff introduces a mechanism to compile and embed tor. We plan on using this functionality on Android and iOS but we have not finished working on updating the build yet. In the meanwhile, here's an interim result. We're committing the code to run unit and integration testing of this new functionality on linux/amd64.
The reference issue is ooni/probe#2365.
The Go based build was sketched out in ooni/probe#2401.