fix(netxlite): allow overriding default cert pool #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff tweaks #1068 to make sure overriding the default cert pool works. In #1068 we introduced code to add this functionality but we never tested it was working as intended. It turns out it was not! Because this diff amends the previous diff, we'll consider it part of ooni/probe#2135.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff tweaks #1068 to make sure overriding the default cert pool works.
In #1068 we introduced code to add this functionality but we never tested it was working as intended. It turns out it was not!
Because this diff amends the previous diff, we'll consider it part of ooni/probe#2135.