fix(libtor): don't leak a file descriptor #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discovered while trying to understand the reason why we have an abort caused by Android's fdsan. This is not the reason why we abort, but it seems correct to fix this issue anyway. Part of ooni/probe#2405
If we don't run it, we don't test the code. So, it was not just building but also making sure tests passed.
Previously we were hanging because we still had an open reference to the socket when the context expired since the filep was closed using defer.
bassosimone
added a commit
that referenced
this pull request
Feb 3, 2023
Discovered while trying to understand the reason why we have an abort caused by Android's fdsan. This is not the reason why we abort, but it seems correct to fix this issue anyway. While there, notice that stopping to run libtorlinux for every PR (which we just did in 5ebcca2) was wrong. We need to run this workflow for every PR because it runs tests for the libtor integration. Part of ooni/probe#2405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while trying to understand the reason why we have an abort caused by Android's fdsan.
This is not the reason why we abort, but it seems correct to fix this issue anyway.
While there, notice that stopping to run libtorlinux for every PR (which we just did in 5ebcca2) was wrong. We need to run this workflow for every PR because it runs tests for the libtor integration.
Part of ooni/probe#2405