feat(netemx): redesign to simplify usage #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
added a commit
to ooni/2023-05-richer-input
that referenced
this pull request
Jul 4, 2023
This diff deals the fallback from ooni/probe-cli#1168 and is related to ooni/probe#2493. After updating netemx, I noticed I lost confidence about the code being WAI, so I implemented metrics to count the number of events.
bassosimone
added a commit
to ooni/2023-05-richer-input
that referenced
this pull request
Jul 4, 2023
This diff deals the fallback from ooni/probe-cli#1168 and is related to ooni/probe#2493. After updating netemx, I noticed I lost confidence about the code being WAI, so I implemented metrics to count the number of events.
2 tasks
cyBerta
pushed a commit
to cyBerta/probe-cli
that referenced
this pull request
Aug 4, 2023
This commit shuffles around the `netemx` implementation to simplify construction and usage. Here are some design goals that underpin this set of changes: 1. construction using optional functions and sane defaults, so one needs to write much less; 2. we always want an HTTP server listening 80/tcp, 443/tcp, and 443/udp, so we can simplify the code *a lot*. I worked on this change while trying to wrap up with ooni/probe#2493. My main aim was to add netem based smoke testing to Web Connectivity LTE such that we can start increasing the amount of users using it with some extra confidence compared to the current situation where code coverage is very low.
cyBerta
pushed a commit
to cyBerta/probe-cli
that referenced
this pull request
Aug 4, 2023
This commit shuffles around the `netemx` implementation to simplify construction and usage. Here are some design goals that underpin this set of changes: 1. construction using optional functions and sane defaults, so one needs to write much less; 2. we always want an HTTP server listening 80/tcp, 443/tcp, and 443/udp, so we can simplify the code *a lot*. I worked on this change while trying to wrap up with ooni/probe#2493. My main aim was to add netem based smoke testing to Web Connectivity LTE such that we can start increasing the amount of users using it with some extra confidence compared to the current situation where code coverage is very low.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This commit shuffles around the `netemx` implementation to simplify construction and usage. Here are some design goals that underpin this set of changes: 1. construction using optional functions and sane defaults, so one needs to write much less; 2. we always want an HTTP server listening 80/tcp, 443/tcp, and 443/udp, so we can simplify the code *a lot*. I worked on this change while trying to wrap up with ooni/probe#2493. My main aim was to add netem based smoke testing to Web Connectivity LTE such that we can start increasing the amount of users using it with some extra confidence compared to the current situation where code coverage is very low.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit shuffles around the
netemximplementation to simplify construction and usage. Here are some design goals that underpin this set of changes:construction using optional functions and sane defaults, so one needs to write much less;
we always want an HTTP server listening 80/tcp, 443/tcp, and 443/udp, so we can simplify the code a lot.
I worked on this change while trying to wrap up with ooni/probe#2493. My main aim was to add netem based smoke testing to Web Connectivity LTE such that we can start increasing the amount of users using it with some extra confidence compared to the current situation where code coverage is very low.