fix: anomaly with android_dns_cache_no_data and inconsistent dns #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff changes the handling of android_dns_cache_no_data to mark it and any other DNS inconsistenct as DNS anomaly. The previous implementation was not handling any DNS inconsistency as an anomaly, therefore I needed to adjust a bunch of summary_test.go tests. Part of ooni/probe#2499 and ooni/probe#2029. I bumped the version number because this is a significant change in the analysis algorithm implemented by the probe.
bassosimone
changed the title
bassosimone
commented
Oct 10, 2023
bassosimone
commented
Oct 10, 2023
bassosimone
commented
Oct 10, 2023
bassosimone
commented
Oct 10, 2023
This was referenced Oct 10, 2023
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
…i#1211) ## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2499 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: N/A - [x] if you changed code inside an experiment, make sure you bump its version number ## Summary This diff changes the `summary.go` algorithm of Web Connectivity v0.4 to handle `android_dns_cache_no_data` as an anomaly when the DNS is inconsistent. We continue handling `dns_nxdomain_error` as an anomaly when the DNS is inconsistent, as demonstrated by the fact that the corresponding netem test is still passing. This diff also bumps the version number to v0.4.3. Version v0.4.2 did not handle this case, which caused measurements to be marked as failed as documented by ooni/probe#2499. This diff is also related to ooni/probe#2029, in the sense that it is slightly improving our analysis results when the is an NXDOMAIN error (even if it's masked by Android's DNS cache behavior). While there, add empty lines to improve the code readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Summary
This diff changes the
summary.goalgorithm of Web Connectivity v0.4 to handleandroid_dns_cache_no_dataas an anomaly when the DNS is inconsistent. We continue handlingdns_nxdomain_erroras an anomaly when the DNS is inconsistent, as demonstrated by the fact that the corresponding netem test is still passing.This diff also bumps the version number to v0.4.3. Version v0.4.2 did not handle this case, which caused measurements to be marked as failed as documented by ooni/probe#2499.
This diff is also related to ooni/probe#2029, in the sense that it is slightly improving our analysis results when the is an NXDOMAIN error (even if it's masked by Android's DNS cache behavior).
While there, add empty lines to improve the code readability.