feat(netxlite): use *Netx for creating DoH resolvers #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on removing technical debt, as part of ooni/probe#2531, it makes sense ensuring that there is a single way of constructing netxlite types by always using an instance of *Netx. This job is relatively easy because we are a couple of patches away from achieving this goal and, by doing this, we would avoid creating future technical debt. So, I am going to ahead and implement this. Also, apparently, the oohelperd uses this functionality and somehow we missed doing this when converting it to using netemx. We should fix this soon.
bassosimone
force-pushed
the
issue/2531
branch
from
1059367
to
fd5782b
Compare
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
While working on removing technical debt, as part of ooni/probe#2531, it makes sense ensuring that there is a single way of constructing netxlite types by always using an instance of *Netx. This job is relatively easy because we are a couple of patches away from achieving this goal and, by doing this, we would avoid creating future technical debt. So, I am going to ahead and implement this. Also, apparently, the oohelperd uses this functionality and somehow we missed doing this when converting it to using netemx. We should fix this soon. (This issue immediately validates what I was saying above about techdebt 😅)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on removing technical debt, as part of ooni/probe#2531, it makes sense ensuring that there is a single way of constructing netxlite types by always using an instance of *Netx. This job is relatively easy because we are a couple of patches away from achieving this goal and, by doing this, we would avoid creating future technical debt. So, I am going to ahead and implement this.
Also, apparently, the oohelperd uses this functionality and somehow we missed
doing this when converting it to using netemx. We should fix this soon. (This issue
immediately validates what I was saying above about techdebt 😅)