feat(UnderlyingNetwork): add support for ListenTCP #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lack of this support already created some difficulties inside the testingx package and I am increasinglty sick of it. Added while looking into moving forward with making beacons fully testable using netem, per ooni/probe#2531.
bassosimone
added a commit
that referenced
this pull request
Sep 15, 2023
This diff adds the ListenTCP function to the *Netx struct. With this addition, based on #1278, we can remove some techdebt inside the testingx package. This is yak shaving while trying to add support for testing socks5 in the context of ooni/probe#2531.
bassosimone
added a commit
that referenced
this pull request
Sep 15, 2023
This diff adds the ListenTCP function to the *Netx struct. With this addition, based on #1278, we can remove some techdebt inside the testingx package. This is yak shaving while trying to add support for testing socks5 in the context of ooni/probe#2531.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
The lack of this support already created some difficulties inside the testingx package and I am increasinglty sick of it. While there, see to increase the testing coverage of the netxlite package. While there acknowledge and commit workaround for ooni/probe#2537. Added while looking into moving forward with making beacons fully testable using netem, per ooni/probe#2531.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff adds the ListenTCP function to the *Netx struct. With this addition, based on ooni#1278, we can remove some techdebt inside the testingx package. This is yak shaving while trying to add support for testing socks5 in the context of ooni/probe#2531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of this support already created some difficulties inside the testingx package and I am increasinglty sick of it.
While there, see to increase the testing coverage of the netxlite package.
While there acknowledge and commit workaround for ooni/probe#2537.
Added while looking into moving forward with making beacons fully testable using netem, per ooni/probe#2531.