feat(enginenetx): make sure HTTPSDialer closes all connections #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the code introduced in the previous commit, i.e., ac13e53. Part of ooni/probe#2531.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
…1285) This uses the code introduced in the previous commit, i.e., ooni@ac13e53. I think it's good to have additional confidence that the `HTTPSDialer` does not leak connections. (Ideally, we would like to verify that we're not leaking connections everywhere, but for now just doing it for new code would do okay.) While there, repair a test that was flaky because of nondeterministic channel selection. Part of ooni/probe#2531.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the code introduced in the previous commit, i.e., ac13e53.
I think it's good to have additional confidence that the
HTTPSDialerdoes not leak connections. (Ideally, we would like to verify that we're not leaking connections everywhere, but for now just doing it for new code would do okay.)While there, repair a test that was flaky because of nondeterministic channel selection.
Part of ooni/probe#2531.