refactor(enginenetx): introduce stats and make tactic a struct #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff refactors the code to introduce a stats interface and to make the tactic a struct ~without methods attached. We transform the tactic into a struct because we're planning on storing the tactics on disk and loading them. We need stats to track what is working and choose which is the best tactic that we should employ. In light of these two needs, it makes sense to transfer the reporting methods that previously were part of the tactic interface to stats. Part of ooni/probe#2531
bassosimone
changed the title
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
…1291) This diff refactors the code to introduce a stats interface and to make the tactic a struct ~without methods attached. We transform the tactic into a struct because we're planning on storing the tactics on disk and loading them. We need stats to track what is working and choose which is the best tactic that we should employ. In light of these two needs, it makes sense to transfer the reporting methods that previously were part of the tactic interface to stats. With this diff, we temporarily lost the possibility of choosing which handshaker to use, which was not implemented anyway and needs some more work to reason about how we'd store this information on disk. Part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff refactors the code to introduce a stats interface and to make the tactic a struct ~without methods attached.
We transform the tactic into a struct because we're planning on storing the tactics on disk and loading them.
We need stats to track what is working and choose which is the best tactic that we should employ.
In light of these two needs, it makes sense to transfer the reporting methods that previously were part of the tactic interface to stats.
With this diff, we temporarily lost the possibility of choosing which handshaker to use, which was not implemented anyway and needs some more work to reason about how we'd store this information on disk.
Part of ooni/probe#2531