fix(enginenetx): refine the happy-eyeballs algorithm #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to pack attempts in parallel, which we also did before when the interval between attempts was linear. We need to take into account possible congestion, so we should push back exponentially, even though the common case for us is probably censorship (we it is better to do the right thing anyway). So, let's scale exponentially until we reach 30s. After that, it's fine to keep attempts evenly spaces, because that is quite a huge interval if we're reasoning in internet time. Also, change the base value used for TLS handshaking to be 900ms rather than 300ms, because a TLS handshake is ~3 round trips. Part of ooni/probe#2531
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
We want to pack attempts in parallel, which we also did before when the interval between attempts was linear. We need to take into account possible congestion, so we should push back exponentially, even though the common case for us is probably censorship (but it is better to do the right thing anyway). So, let's scale exponentially until we reach 30s. After that, it's fine to keep attempts evenly spaces, because 30s is quite definitely a huge interval if we're reasoning in internet time. Also, change the base value used for TLS handshaking to be 900ms rather than 300ms, because a TLS handshake is ~3 round trips. Part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to pack attempts in parallel, which we also did before when the interval between attempts was linear.
We need to take into account possible congestion, so we should push back exponentially, even though the common case for us is probably censorship (but it is better to do the right thing anyway).
So, let's scale exponentially until we reach 30s. After that, it's fine to keep attempts evenly spaces, because 30s is quite definitely a huge interval if we're reasoning in internet time.
Also, change the base value used for TLS handshaking to be 900ms rather than 300ms, because a TLS handshake is ~3 round trips.
Part of ooni/probe#2531