feat(enginenetx): track operations and collect stats #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff modifies the enginenetx package such that we track the results of operations we perform and collect statistics. The statistics will be saved in the `StateDir` where we already save other statistics, e.g., the ones related to DoH. Part of ooni/probe#2531
bassosimone
commented
Sep 25, 2023
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff modifies the enginenetx package such that we track the results of operations we perform and collect statistics. The statistics will be saved in the `StateDir` where we already save other statistics, e.g., the ones related to DoH. While there, realize that we should also count the number of interrupted operations. Also, realize that the TLS verification cannot be interrupted, so there's no point in passing a `ctx` to the related stats manager callback. Part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff modifies the enginenetx package such that we track the results of operations we perform and collect statistics.
The statistics will be saved in the
StateDirwhere we already save other statistics, e.g., the ones related to DoH.While there, realize that we should also count the number of interrupted operations. Also, realize that the TLS verification cannot be interrupted, so there's no point in passing a
ctxto the related stats manager callback.Part of ooni/probe#2531