refactor(enginenetx): make static-policy API private #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've more or less reached the point where we wanted to be with ooni/probe#2531, let's spend some time to refactor the implementation, now that we know very well how to works, such that modifying it in the future would be easier. The first order of business here seems to hide implementation details and get rid of too many HTTPSDialer prefixes which only cause confusion when looking at the available structs. Here, in particular, we deal with the static-policy API. To this end, we also need to more some tests around because they need internals. Also, while there, add a top-level description to some files, so that newcomers have an idea of what each file is about.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
Now that we've more or less reached the point where we wanted to be with ooni/probe#2531, let's spend some time to refactor the implementation, now that we know very well how it works, such that modifying it in the future would be easier. The first order of business here seems to hide implementation details and get rid of too many HTTPSDialer prefixes which only cause confusion when looking at the available structs. Here, in particular, we deal with the static-policy API. To this end, we also need to more some tests around because they need internals. Also, while there, add a top-level description to some files, so that newcomers have an idea of what each file is about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've more or less reached the point where we wanted to be with ooni/probe#2531, let's spend some time to refactor the implementation, now that we know very well how it works, such that modifying it in the future would be easier.
The first order of business here seems to hide implementation details and get rid of too many HTTPSDialer prefixes which only cause confusion when looking at the available structs.
Here, in particular, we deal with the static-policy API. To this end, we also need to more some tests around because they need internals.
Also, while there, add a top-level description to some files, so that newcomers have an idea of what each file is about.