feat(enginenetx): support getting stats on a domain endpoint #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear which files contain policies and which contain state trackers. Useful because upcoming changes will add files containing state-based policy. Part of ooni/probe#2531
We need this functionality to ask the stats questions like "what are all the available tactics for www.example.com:443 along with their stats?". In turn, this information is needed to implement a new policy that uses existing stats to choose what to do. Part of ooni/probe#2531
bassosimone
changed the title
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
We need this functionality to ask the stats questions like "what are all the available tactics for www.example.com:443 along with their stats?". In turn, this information is needed to implement a new policy that uses existing stats to choose what to do. While there, rename files to make it clear which files contain policies and which contain state trackers. Useful because upcoming changes will add files containing state-based policy. While there, stop being paranoid about cloning a nil map to a nil map, acknowledge this is not important and making it round trip correctly would require more code we don't need, and simply adjust tests to accept nil and empty map as equal. Part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this functionality to ask the stats questions like "what are all the available tactics for www.example.com:443 along with their stats?". In turn, this information is needed to implement a new policy that uses existing stats to choose what to do.
While there, rename files to make it clear which files contain policies and which contain state trackers. Useful because upcoming changes will add files containing state-based policy.
While there, stop being paranoid about cloning a nil map to a nil map, acknowledge this is not important and making it round trip correctly would require more code we don't need, and simply adjust tests to accept nil and empty map as equal.
Part of ooni/probe#2531