refactor(model): simplify using ArchivalBinaryData #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It did not originally occur to me, but now it's clear that we can avoid using a struct to wrap the data type. It just suffices to use the new type. I think this is better in terms of writing code because the only two things we need to do are: 1. make sure we have serialization and unserialization tests; 2. use the correct data type in the struct. For all intents and purposes the ArchivalBinaryData is just a special kind of []byte attached to custom marshal/unmarshal rules. Part of ooni/probe#2531
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
It did not originally occur to me, but now it's clear that we can avoid using a struct to wrap the data type. It just suffices to use the new type. I think this is better in terms of writing code because the only two things we need to do are: 1. make sure we have serialization and unserialization tests; 2. use the correct data type in the struct. For all intents and purposes the ArchivalBinaryData is just a special kind of []byte attached to custom marshal/unmarshal rules. Part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It did not originally occur to me, but now it's clear that we can avoid using a struct to wrap the data type.
It just suffices to use the new type.
I think this is better in terms of writing code because the only two things we need to do are:
make sure we have serialization and unserialization tests;
use the correct data type in the struct.
For all intents and purposes the ArchivalBinaryData is just a special kind of []byte attached to custom marshal/unmarshal rules.
Part of ooni/probe#2531