New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ArchivalMaybeBinaryString type #1325

Merged

bassosimone merged 2 commits into master from issue/2531

Sep 28, 2023

Contributor

bassosimone commented Sep 28, 2023

This type is ~equivalent to ArchivalMaybeBinaryData but designed to hold a string, do less type conversions, and be easier to use.

The intent is to replace the ArchivalMaybeBinaryData type with this type.

For now, let us introduce the new type and its tests.

Part of ooni/probe#2531


feat: add ArchivalMaybeBinaryString type

e7c290a

This type is ~equivalent to ArchivalMaybeBinaryData but designed to hold
a string, do less type conversions, and be easier to use.

The intent is to replace the ArchivalMaybeBinaryData type with this type.

For now, let us introduce the new type and its tests.

Part of ooni/probe#2531

bassosimone requested a review from hellais as a code owner

September 28, 2023 13:45

bassosimone commented

View reviewed changes

internal/model/archival.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/model/archival_test.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/model/archival_test.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/model/archival_test.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/model/archival_test.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/model/archival_test.go Outdated Show resolved Hide resolved

bassosimone commented

View reviewed changes

internal/model/archival_test.go Outdated Show resolved Hide resolved


Apply suggestions from code review

d141a89

bassosimone merged commit b8db342 into master

6 checks passed

bassosimone deleted the issue/2531 branch

September 28, 2023 13:57

bassosimone mentioned this pull request

engine: adapt to use bridges ooni/probe#2531

Closed

Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request


feat: add ArchivalMaybeBinaryString type (ooni#1325)

64154e0

This type is ~equivalent to ArchivalMaybeBinaryData but designed to hold
a string, do less type conversions, and be easier to use.

The intent is to replace the ArchivalMaybeBinaryData type with this
type.

For now, let us introduce the new type and its tests.

Part of ooni/probe#2531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment