chore: write tests for ArchivalDNSLookupResult #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My aim here is to have marshal/unmarshal tests for all the toplevel data structures inside the internal/model/archival.go file. Once I have done that, I can have additional confidence about changing the structure fields and simplifying the code. All of this is preparatory work to automatically scrub HTTP measurements which is something we should really do before continuing to improve the boostrap process in light of ooni/probe#2531. I have also added currently skipped tests for other structures as placeholder, but I did not want to submit a too large PR, hence for now we will just have tests for ArchivalDNSLookupResult. More PRs will follow and they will add additional unit tests.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
My aim here is to have marshal/unmarshal tests for all the toplevel data structures inside the internal/model/archival.go file. Once I have done that, I can have additional confidence about changing the structure fields and simplifying the code. All of this is preparatory work to automatically scrub HTTP measurements which is something we should really do before continuing to improve the boostrap process in light of ooni/probe#2531. I have also added currently skipped tests for other structures as placeholder, but I did not want to submit a too large PR, hence for now we will just have tests for ArchivalDNSLookupResult. More PRs will follow and they will add additional unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My aim here is to have marshal/unmarshal tests for all the toplevel data structures inside the internal/model/archival.go file.
Once I have done that, I can have additional confidence about changing the structure fields and simplifying the code.
All of this is preparatory work to automatically scrub HTTP measurements which is something we should really do before continuing to improve the boostrap process in light of ooni/probe#2531.
I have also added currently skipped tests for other structures as placeholder, but I did not want to submit a too large PR, hence for now we will just have tests for ArchivalDNSLookupResult. More PRs will follow and they will add additional unit tests.