chore: run go generate ./... #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The https://github.com/iancoleman/strcase library changed its default behavior between v0.2.0 and v0.3.0 such that: - before `DNS_NXDOMAIN_error` become `DNSNXDOMAINError`; - after it becomes `DnsNxdomainError`. In the grand scheme of things, perhaps, this change makes sense for the library. However, as a user, what I see is a breaking change between two minor versions (admittedly we're at v0.x). Because I don't know what would happen next and I don't want any more surprising, I am forking the library to v0.2.0. Part of ooni/probe#2524
26 tasks
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
The https://github.com/iancoleman/strcase library changed its default behavior between v0.2.0 and v0.3.0 such that: - before `DNS_NXDOMAIN_error` became `DNSNXDOMAINError`; - now it becomes `DnsNxdomainError`. In the grand scheme of things, perhaps, this change makes sense for the library. However, as a user, what I see is a breaking change between two minor versions (admittedly we're at v0.x). Because I don't know what would happen next and I don't want any more surprises, I am forking strcase@v2.0.0. This work is part of ooni/probe#2524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://github.com/iancoleman/strcase library changed its default behavior between v0.2.0 and v0.3.0 such that:
before
DNS_NXDOMAIN_errorbecameDNSNXDOMAINError;now it becomes
DnsNxdomainError.In the grand scheme of things, perhaps, this change makes sense for the library. However, as a user, what I see is a breaking change between two minor versions (admittedly we're at v0.x).
Because I don't know what would happen next and I don't want any more surprises, I am forking strcase@v2.0.0.
This work is part of ooni/probe#2524