fix(engineresolver): support HTTP/HTTPS proxies #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using netxlite.NewHTTPTransportWithOptions: 1. we remove an unnecessary usage of the quirky HTTP transport used for measuring by ./legacy/netx et al (removing such unnecessary usages is ooni/probe#2534); 2. we enable using HTTP/HTTPS proxies in miniooni and ooniprobe. Closes ooni/probe#1955.
bassosimone
changed the title
bassosimone
commented
Oct 9, 2023
bassosimone
commented
Oct 9, 2023
26 tasks
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
By using netxlite.NewHTTPTransportWithOptions in `./internal/engineresolver/factory.go`: 1. we remove an unnecessary usage of the quirky HTTP transport used for measuring by ./legacy/netx et al (removing such unnecessary usages is ooni/probe#2534); 2. we enable using HTTP/HTTPS proxies in miniooni and ooniprobe. Closes ooni/probe#1955.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using netxlite.NewHTTPTransportWithOptions in
./internal/engineresolver/factory.go:we remove an unnecessary usage of the quirky HTTP transport used for measuring by ./legacy/netx et al (removing such unnecessary usages is engine: reduce usage of quirky netxlite code probe#2534);
we enable using HTTP/HTTPS proxies in miniooni and ooniprobe.
Closes ooni/probe#1955.