feat: mvp of conditionally enabling experiments #1355

bassosimone · 2023-10-10T14:56:10Z

Checklist

I have read the contribution guidelines
reference issue for this pull request: engine: MVP of enabling experimental experiments using richer input probe#2553
if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: N/A
if you changed code inside an experiment, make sure you bump its version number

Description

We have a class of experiments that I call experimental experiments. These are experiments that we just added, so we're not 100% sure about them, or experiments that are historically flaky, so we want to be defensive.

Currently, riseupvpn and echechk fall into this class.

The idea of this diff is to implement the functional specification described by issue ooni/probe#2553.

While there, make sure we have more robust testing for the ./internal/registry package.

While there, make sure package creation logic lives in ./internal/registry rather than in ./internal/engine.

We have a class of experiments that I call experimental experiments. As a reminder, experimental experiments are the ones we have just added in a development cycle and which may potentially have issues down the line, so that we may want to disable them while working on an emergency release to fix them. Currently, riseupvpn and echechk fall into this class. The idea of this diff is to implement the functional specification described by issue ooni/probe#2553.

internal/registry/factory.go

internal/registry/factory_test.go

This diff backports #1355 to the release/3.19 branch. - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2553 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: N/A - [x] if you changed code inside an experiment, make sure you bump its version number We have a class of experiments that I call experimental experiments. These are experiments that we just added, so we're not 100% sure about them, or experiments that are historically flaky, so we want to be defensive. Currently, riseupvpn and echechk fall into this class. The idea of this diff is to implement the functional specification described by issue ooni/probe#2553. While there, make sure we have more robust testing for the `./internal/registry` package. While there, make sure package creation logic lives in `./internal/registry` rather than in `./internal/engine`.

## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2553 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: N/A - [x] if you changed code inside an experiment, make sure you bump its version number ## Description We have a class of experiments that I call experimental experiments. These are experiments that we just added, so we're not 100% sure about them, or experiments that are historically flaky, so we want to be defensive. Currently, riseupvpn and echechk fall into this class. The idea of this diff is to implement the functional specification described by issue ooni/probe#2553. While there, make sure we have more robust testing for the `./internal/registry` package. While there, make sure package creation logic lives in `./internal/registry` rather than in `./internal/engine`.

bassosimone added 6 commits October 10, 2023 16:52

x

b1413ed

x

1c4eb6e

x

994ae6f

x

7eb1579

x

5a592ce