fix(ooniprobe): make sure we actually run echcheck #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there, emit some logs while running it. While there, make the warning emitted when a nettest is disabled much more specific and informative for the user. Part of ooni/probe#2547 Part of ooni/probe#2553
bassosimone
added a commit
that referenced
this pull request
Oct 11, 2023
This diff backports #1358 to the release/3.19 branch. While there, emit some logs while running it. While there, make the warning emitted when a nettest is disabled much more specific and informative for the user. Part of ooni/probe#2547 Part of ooni/probe#2553
26 tasks
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
While there, emit some logs while running it. While there, make the warning emitted when a nettest is disabled much more specific and informative for the user. Part of ooni/probe#2547 Part of ooni/probe#2553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there, emit some logs while running it.
While there, make the warning emitted when a nettest is disabled much more specific and informative for the user.
Part of ooni/probe#2547
Part of ooni/probe#2553