refactor(buildtool): use list for OpenSSL ./Configure flags #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
added a commit
that referenced
this pull request
Oct 12, 2023
This diff backports #1367 to the release/3.19 branch. We currently have a string variable in `cBuildEnv` named `OPENSSL_API_DEFINE` that we append to OpenSSL's `./Configure` invocation to force using the proper Android API. However, for building for iOS (a need documented by ooni/probe#2564), we need a list of strings, because there is more than a single scalar that we need to append to the `./Configure` invocation (as shown by the MVP implementation at #1366). Hence, this diff, which introduces a string list named `OPENSSL_POST_COMPILER_FLAGS` that contains strings to append to the `./Configure` command line _after_ the OS/compiler flag. We specifically named the variable "post compiler" because there is another variable in the same `cBuildEnv` struct called `OPENSSL_COMPILER`.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
We currently have a string variable in `cBuildEnv` named `OPENSSL_API_DEFINE` that we append to OpenSSL's `./Configure` invocation to force using the proper Android API. However, for building for iOS (a need documented by ooni/probe#2564), we need a list of strings, because there is more than a single scalar that we need to append to the `./Configure` invocation (as shown by the MVP implementation at ooni#1366). Hence, this diff, which introduces a string list named `OPENSSL_POST_COMPILER_FLAGS` that contains strings to append to the `./Configure` command line _after_ the OS/compiler flag. We specifically named the variable "post compiler" because there is another variable in the same `cBuildEnv` struct called `OPENSSL_COMPILER`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a string variable in
cBuildEnvnamedOPENSSL_API_DEFINEthat we append to OpenSSL's./Configureinvocation to force using the proper Android API. However, for building for iOS (a need documented by ooni/probe#2564), we need a list of strings, because there is more than a single scalar that we need to append to the./Configureinvocation (as shown by the MVP implementation at #1366).Hence, this diff, which introduces a string list named
OPENSSL_POST_COMPILER_FLAGSthat contains strings to append to the./Configurecommand line after the OS/compiler flag. We specifically named the variable "post compiler" because there is another variable in the samecBuildEnvstruct calledOPENSSL_COMPILER.