fix(signal): trim down tested endpoints #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
bassosimone
added a commit
to ooni/spec
that referenced
this pull request
Dec 1, 2023
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/spec/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2636 - [x] related ooni/probe-cli pull request: ooni/probe-cli#1421 - [x] If I changed a spec, I also bumped its version number and/or date <!-- Location of the issue tracker: https://github.com/ooni/probe --> ## Description We trim down signal endpoints to increase robustness against endpoints churn.
bassosimone
added a commit
that referenced
this pull request
Dec 1, 2023
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2636 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: ooni/spec#282 - [x] if you changed code inside an experiment, make sure you bump its version number <!-- Reminder: Location of the issue tracker: https://github.com/ooni/probe --> ## Description This diff trims down the endpoints tested by signal to avoid the possibility of future churn.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: ooni/probe#2636 - [x] if you changed anything related to how experiments work and you need to reflect these changes in the ooni/spec repository, please link to the related ooni/spec pull request: ooni/spec#282 - [x] if you changed code inside an experiment, make sure you bump its version number <!-- Reminder: Location of the issue tracker: https://github.com/ooni/probe --> ## Description This diff trims down the endpoints tested by signal to avoid the possibility of future churn.
bassosimone
added a commit
to ooni/backend
that referenced
this pull request
Mar 22, 2024
The ooni/probe-cli#1421 PR trimmed the endpoints and bumped signal's version to v0.2.5. So we need to ignore versions of signal lower than v0.2.5. I am wondering whether we should also use a time window because otherwise what happens when we reprocess measurements. If my analysis is correct, then we have an additional issue that there's another check in this codepath that seems to mark signal measurements as failed without any temporal constraints. This would also cause reprocessing to cause downstream issues. Part of ooni/probe#2636
hellais
added a commit
to ooni/backend
that referenced
this pull request
Mar 25, 2024
* fix: mark signal v0.2.4 as failed The ooni/probe-cli#1421 PR trimmed the endpoints and bumped signal's version to v0.2.5. So we need to ignore versions of signal lower than v0.2.5. I am wondering whether we should also use a time window because otherwise what happens when we reprocess measurements. If my analysis is correct, then we have an additional issue that there's another check in this codepath that seems to mark signal measurements as failed without any temporal constraints. This would also cause reprocessing to cause downstream issues. Part of ooni/probe#2636 * Add more specific constraints to the signal scoring logic * Bump changelog entry Fix changelog entry to avoid conflict with: https://github.com/ooni/backend/pull/793/files --------- Co-authored-by: Arturo Filastò <arturo@filasto.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This diff trims down the endpoints tested by signal to avoid the possibility of future churn.