cleanup(miniooni): rename kvstore2 to engine #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures we can parse integer values provided using OONI Run v2 descriptors into actual integers. Values are originally parsed as float64, so we need to add a specific conversion case for that scenario.
Noticed when preparing the SplinterCon demo. We should have the same name for the engine state directory for miniooni and ooniprobe. Otherwise, we need to tell people about this difference.
This is a minimal JavaScript interpreter invokable from miniooni, which seems helpful when doing research in difficult environments where an ordinary compile, ship, test, edit, compile loop is too slow. To implement this interpreter, we use a special purpose DSL that is easier to use from other languages than the current one. Originally at: https://github.com/bassosimone/2023-12-09-ooni-javascript.
This reverts commit 036179c.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
Noticed when preparing the SplinterCon demo. We should have the same name for the engine state directory for miniooni and ooniprobe. Otherwise, we need to tell people about this difference. Extracted from: ooni#1423 Closes: ooni/probe#2646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when preparing the SplinterCon demo. We should have the same
name for the engine state directory for miniooni and ooniprobe.
Otherwise, we need to tell people about this difference.
Extracted from: #1423
Closes: ooni/probe#2646