Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oohelperd,netmx): reduce construction diff to zero #1467

Merged
merged 1 commit into from
Jan 24, 2024

Commits on Jan 24, 2024

  1. refactor(oohelperd,netmx): reduce construction diff to zero

    This diff modifies how we construct oohelperd.Handler inside the
    oohelperd package and inside the netemx package such that we're now
    constructing using equivalent code. We know that construction is
    equivalent for HTTP clients because previosuly we made sure it was
    the case in #1464.
    
    So, the next step would be removing the custom construction code
    inside of netemx and always use oohelperd.NewHandler.
    
    In turn, by doing this, we would ensure we have the same `oohelperd`
    behavior for QA and production.
    
    In turn, with this guarantee, we can write QA tests that ensure we're
    correctly dealing with 127.0.0.1.
    
    The reference issue is ooni/probe#1517.
    bassosimone committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    c16ac9b View commit details
    Browse the repository at this point in the history