fix(webconnectivitylte): handle domains w/o A/AAAA records #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff improves webconnectivitylte and minipipeline to correctly handle the case where a website has no configured IP addresses but the domain for the website exists. Let's also add QA test cases to make sure we don't regress. Part of ooni/probe#2652.
bassosimone
commented
Jan 24, 2024
bassosimone
commented
Jan 24, 2024
bassosimone
commented
Jan 24, 2024
bassosimone
changed the title
bassosimone
changed the title
bassosimone
changed the title
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff improves webconnectivitylte and minipipeline to correctly handle the case where a website has no configured IP addresses but the domain for the website exists. When this happens, the TH returns no error but an empty list of resolved addresses for historical reasons, while the probe fails with the `"dns_no_answer"` error. We need to intercept and correctly handle this scenario both for the ordinary analysis and the classic analysis. Let's also add QA test cases to make sure we don't regress. Part of ooni/probe#2652.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff improves webconnectivitylte and minipipeline to correctly handle the case where a website has no configured IP addresses but the domain for the website exists. When this happens, the TH returns no error but an empty list of resolved addresses for historical reasons, while the probe fails with the
"dns_no_answer"error. We need to intercept and correctly handle this scenario both for the ordinary analysis and the classic analysis.Let's also add QA test cases to make sure we don't regress.
Part of ooni/probe#2652.