Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(webconnectivityqa): reproduce ooni/probe#2628 issue #1479

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Jan 31, 2024

This PR improves webconnectivityqa to reproduce the ooni/probe#2628 issue.

We model the v0.4 behavior as the correct behavior. We need to extend webconnectivitylte to correctly handle this case.

@bassosimone bassosimone changed the title we start to understand how to reproduce chore(webconnectivityqa): reproduce probe#1628 issue Jan 31, 2024
@bassosimone bassosimone marked this pull request as ready for review January 31, 2024 13:29
@bassosimone bassosimone requested a review from hellais as a code owner January 31, 2024 13:29
@bassosimone bassosimone changed the title chore(webconnectivityqa): reproduce probe#1628 issue chore(webconnectivityqa): reproduce probe#2628 issue Jan 31, 2024
@bassosimone bassosimone changed the title chore(webconnectivityqa): reproduce probe#2628 issue chore(webconnectivityqa): reproduce ooni/probe#2628 issue Jan 31, 2024
@bassosimone bassosimone merged commit 69a6c89 into master Jan 31, 2024
11 checks passed
@bassosimone bassosimone deleted the issue/2628 branch January 31, 2024 13:35
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request Feb 13, 2024
This PR improves webconnectivityqa to reproduce the
ooni/probe#2628 issue.

We model the v0.4 behavior as the correct behavior. We need to extend
webconnectivitylte to correctly handle this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant