Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webconnectivitylte): use scope for endpoint IDs #1507

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

bassosimone
Copy link
Contributor

We use scope for endpoint IDs. This helps to reduce churn when running ./script/updateminipipeline.bash.

Part of ooni/probe#2677

This diff uses scopes for the endpoints. By doing this, we should be able
to structurally reduce the churn in output measurement results.
The purpose of re-running is showing that we have reduced the
churn since the previous commit.
@bassosimone bassosimone requested a review from hellais as a code owner February 12, 2024 19:18
@bassosimone bassosimone merged commit 165a9ac into master Feb 12, 2024
25 checks passed
@bassosimone bassosimone deleted the issue/2677c branch February 12, 2024 19:26
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request Feb 13, 2024
We use scope for endpoint IDs. This helps to reduce churn when running
`./script/updateminipipeline.bash`.

Part of ooni/probe#2677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant