cleanup: SaveMeasurement doesn't belong to Experiment #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleanup may be a bit tangential, but it still makes sense in the context of what I'm doing, i.e., cleaning up the engine API and ensuring we mostly use engine functionality in clients. While doing this, it occurred to me that I could avoid keeping the SaveMeasurement method attached to an experiment, and I could instead just make it a pure function. This reduces the complexity of the *engine.Experiment type. While there, slightly improve testing. Part of ooni/probe#2700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleanup may be a bit tangential, but it still makes sense in the context of what I'm doing, i.e., cleaning up the engine API and ensuring we mostly use engine functionality in clients.
While doing this, it occurred to me that I could avoid keeping the SaveMeasurement method attached to an experiment, and I could instead just make it a pure function.
This reduces the complexity of the *engine.Experiment type.
While there, slightly improve testing.
Part of ooni/probe#2700