cleanup(probeservices): remove residual httpx.Client dependency #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally thought about dropping support for cloudfronting given that we are not using it anymore. I wonder why. It's a few lines of code (including testing) and it seems a good idea to keep supporting it. Part of ooni/probe#2723
Conflicts: internal/httpclientx/getjson_test.go internal/httpclientx/getraw_test.go internal/httpclientx/getxml_test.go internal/httpclientx/postjson_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff removes the residual httpx.Client dependency of probeservices. While there, recognize that we were not testing for cloudfront hard enough and add more testing for this feature. Part of ooni/probe#2723.